Page MenuHomePhabricator

Update doc/release-process.md
ClosedPublic

Authored by Mengerian on Jul 9 2019, 03:37.

Details

Summary

Move version number bump step to directly after git tag
Move IBD step to after Gitian Build
Add "with and without" assumevalid=0 and checkpoints=0 for IBD
Make capitalization of "Gitian Build" consistent
Move AUR/PPA/Docker builder notification earlier
Move Qt test step earlier, and expand description

Test Plan

Release manager verify that checklist corresponds to the
order he actually follows during a release.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Mengerian created this revision.Jul 9 2019, 03:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2019, 03:37
Fabien requested changes to this revision.Jul 9 2019, 05:35
Fabien added a subscriber: Fabien.

While you're at it...

doc/release-process.md
32 ↗(On Diff #10120)

This should be moved to the section Verify tests passed, if something fails here you want to fix it first.
It also would be good to add/replace with something stating that all supported platforms should be checked:
Ensure that bitcoind and bitcoin-qt run with no issue on all supported platforms. Manually test bitcoin-qt by sending some transactions and navigating through the menus.
Note: I understand supported platforms as all the platforms for which binaries are distributed as part of this release process.

49 ↗(On Diff #10120)

I'm not sure this is the right place, you might want to publish a release somewhere first (e.g. on github).
IIRC the request on slack was to be notified of the coming release earlier so the maintainers can prepare themself to build their package. Maybe simply reword to something like this:
Notify maintainers of Ubuntu PPA, AUR, and Docker images that the release process has started so that they can build their packages as soon as it is available.

51 ↗(On Diff #10120)

both with and without IBD with -checkpoints=0 -assumevalid=0

This revision now requires changes to proceed.Jul 9 2019, 05:35
Mengerian updated this revision to Diff 10132.Jul 9 2019, 15:12
Mengerian edited the summary of this revision. (Show Details)
Mengerian removed a reviewer: Fabien.

Update per @Fabien comments

Mengerian marked 3 inline comments as done.Jul 9 2019, 15:16
Mengerian added inline comments.
doc/release-process.md
49 ↗(On Diff #10120)

Ok, for this item I just moved it back close to where it was before, the only difference is that it's now in the "release" section rather than the "after release" section.

It makes sense to notify those people when it's actually ready for them, so I though it makes more sense this way. At least moving it to the "release" section makes it seem like the release manager shouldn't wait until after release to notify them.

Fabien accepted this revision.Jul 9 2019, 15:19
Fabien added inline comments.
doc/release-process.md
49 ↗(On Diff #10120)

Sounds good to me

This revision is now accepted and ready to land.Jul 9 2019, 15:19
jasonbcox added inline comments.Jul 9 2019, 15:42
doc/release-process.md
58 ↗(On Diff #10132)

Maintainers have requested 1-day advance notice, so we should make a note of that here.

Mengerian updated this revision to Diff 10143.Jul 9 2019, 18:15
Mengerian marked an inline comment as done.

Update per @jasonbcox feedback

This revision was automatically updated to reflect the committed changes.