Page MenuHomePhabricator

Fix null pointer dereference in SendCoinsEntry
AbandonedPublic

Authored by Fabien on Jul 11 2019, 08:58.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Summary

The WalletModel model member is initialized to null, then accessed to
set the label tooltip (introduced in D3351).

This diff removes the call which was added in D466, as the tooltip is
invisible by default and will get overriden by user messages.

Note: I couldn't make this tooltip appear at all (neither on core)

Test Plan

Start bitcoin-qt with UBSAN.
Run test_bitcoin-qt with UBSAN.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_nullwallet_sendcoinsentry
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6821
Build 11689: Bitcoin ABC Teamcity Staging
Build 11688: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 11 2019, 08:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2019, 08:58
deadalnix requested changes to this revision.Jul 11 2019, 11:13

This is reintroducing global state, so no.

This revision now requires changes to proceed.Jul 11 2019, 11:13
Fabien edited the summary of this revision. (Show Details)Jul 11 2019, 15:55
Fabien updated this revision to Diff 10230.Jul 11 2019, 16:10

Just remove the tooltip message entirely.

jasonbcox accepted this revision.Jul 11 2019, 17:23
deadalnix requested changes to this revision.Jul 11 2019, 17:23

That's not good either. Removing the tooltip doesn't fix the problem.

This revision now requires changes to proceed.Jul 11 2019, 17:23
Fabien abandoned this revision.Jul 25 2019, 09:11

Superseeded by D3720