Paths

Table of Contentst

Fix null pointer dereference in SendCoinsEntry
AbandonedPublic
Actions

Authored by Fabien on Jul 11 2019, 08:58.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Summary

The WalletModel model member is initialized to null, then accessed to
set the label tooltip (introduced in D3351).

This diff removes the call which was added in D466, as the tooltip is
invisible by default and will get overriden by user messages.

Note: I couldn't make this tooltip appear at all (neither on core)

Test Plan

Start bitcoin-qt with UBSAN.
Run test_bitcoin-qt with UBSAN.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_nullwallet_sendcoinsentry

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6821
Build 11689: Bitcoin ABC Buildbot (legacy)
Build 11688: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 11 2019, 08:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2019, 08:58

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6819: Diff 10226.Jul 11 2019, 09:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

This is reintroducing global state, so no.

This revision now requires changes to proceed.Jul 11 2019, 11:13

Fabien edited the summary of this revision. (Show Details)Jul 11 2019, 15:55

Just remove the tooltip message entirely.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6821: Diff 10230.Jul 11 2019, 16:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Jul 11 2019, 17:23

That's not good either. Removing the tooltip doesn't fix the problem.

This revision now requires changes to proceed.Jul 11 2019, 17:23

Superseeded by D3720

Revision Contents
Changeset List

Path

Size

src/

qt/

locale/

bitcoin_ca.ts

4 lines

bitcoin_ca@valencia.ts

4 lines

4 lines

4 lines

4 lines

4 lines

5 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

8 lines

Diff 10230

View Options

src/qt/locale/bitcoin_ca.ts

View Options

src/qt/locale/bitcoin_ca@valencia.ts

View Options

src/qt/locale/bitcoin_ca_ES.ts

View Options

src/qt/locale/bitcoin_cs.ts

View Options

src/qt/locale/bitcoin_da.ts

View Options

src/qt/locale/bitcoin_de.ts

View Options

src/qt/locale/bitcoin_en.ts

View Options

src/qt/locale/bitcoin_en_GB.ts

View Options

src/qt/locale/bitcoin_es.ts

View Options

src/qt/locale/bitcoin_es_ES.ts

View Options

src/qt/locale/bitcoin_fi.ts

View Options

src/qt/locale/bitcoin_fr.ts

View Options

src/qt/locale/bitcoin_he.ts

View Options

src/qt/locale/bitcoin_it.ts

View Options

src/qt/locale/bitcoin_ja.ts

View Options

src/qt/locale/bitcoin_ka.ts

View Options

src/qt/locale/bitcoin_ko_KR.ts

View Options

src/qt/locale/bitcoin_nb.ts

View Options

src/qt/locale/bitcoin_ne.ts

View Options

src/qt/locale/bitcoin_nl.ts

View Options

src/qt/locale/bitcoin_pl.ts

View Options

src/qt/locale/bitcoin_pt_BR.ts

View Options

src/qt/locale/bitcoin_pt_PT.ts

View Options

src/qt/locale/bitcoin_ro_RO.ts

View Options

src/qt/locale/bitcoin_ru.ts

View Options

src/qt/locale/bitcoin_sk.ts

View Options

src/qt/locale/bitcoin_sl_SI.ts

View Options

src/qt/locale/bitcoin_sv.ts

View Options

src/qt/locale/bitcoin_tr.ts

View Options

src/qt/locale/bitcoin_uk.ts

View Options

src/qt/locale/bitcoin_zh_CN.ts

View Options

src/qt/locale/bitcoin_zh_TW.ts

View Options

Fix null pointer dereference in SendCoinsEntryAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10230

src/qt/locale/bitcoin_ca.ts

src/qt/locale/bitcoin_ca@valencia.ts

src/qt/locale/bitcoin_ca_ES.ts

src/qt/locale/bitcoin_cs.ts

src/qt/locale/bitcoin_da.ts

src/qt/locale/bitcoin_de.ts

src/qt/locale/bitcoin_en.ts

src/qt/locale/bitcoin_en_GB.ts

src/qt/locale/bitcoin_es.ts

src/qt/locale/bitcoin_es_ES.ts

src/qt/locale/bitcoin_fi.ts

src/qt/locale/bitcoin_fr.ts

src/qt/locale/bitcoin_he.ts

src/qt/locale/bitcoin_it.ts

src/qt/locale/bitcoin_ja.ts

src/qt/locale/bitcoin_ka.ts

src/qt/locale/bitcoin_ko_KR.ts

src/qt/locale/bitcoin_nb.ts

src/qt/locale/bitcoin_ne.ts

src/qt/locale/bitcoin_nl.ts

src/qt/locale/bitcoin_pl.ts

src/qt/locale/bitcoin_pt_BR.ts

src/qt/locale/bitcoin_pt_PT.ts

src/qt/locale/bitcoin_ro_RO.ts

src/qt/locale/bitcoin_ru.ts

src/qt/locale/bitcoin_sk.ts

src/qt/locale/bitcoin_sl_SI.ts

src/qt/locale/bitcoin_sv.ts

src/qt/locale/bitcoin_tr.ts

src/qt/locale/bitcoin_uk.ts

src/qt/locale/bitcoin_zh_CN.ts

src/qt/locale/bitcoin_zh_TW.ts

src/qt/sendcoinsentry.cpp

Fix null pointer dereference in SendCoinsEntry
AbandonedPublic
Actions

Revision Contents
Changeset List