Pass WalletModel down to SendCoinsEntry by construct
ClosedPublic
Actions

Authored by deadalnix on Jul 23 2019, 16:53.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING876ddfaff7c9: Pass WalletModel down to SendCoinsEntry by construct
rABC876ddfaff7c9: Pass WalletModel down to SendCoinsEntry by construct

Summary

This ensures the wallet model is passed down in constructors so that the SendCoinsEntry has it right away.

Test Plan

make check

Make sure the ubsan build is now fixed.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 23 2019, 16:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2019, 16:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B6923: Diff 10406.Jul 23 2019, 16:59

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix retitled this revision from Pass WalletModel down to SendCoinsEntry y construct to Pass WalletModel down to SendCoinsEntry by construct.Jul 23 2019, 17:43

jasonbcox requested changes to this revision.Jul 23 2019, 18:38

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/qt/sendcoinsdialog.cpp
143 ↗	(On Diff #10406)	nit: this comment isn't useful
src/qt/sendcoinsentry.cpp
102 ↗	(On Diff #10406)	This doesn't appear to depend on the options model.

This revision now requires changes to proceed.Jul 23 2019, 18:38

deadalnix added inline comments.Jul 23 2019, 23:18

src/qt/sendcoinsdialog.cpp
143 ↗	(On Diff #10406)	Yes, the model has been set, but there are triggers that need to run when it is set which have not run yet.
src/qt/sendcoinsentry.cpp
102 ↗	(On Diff #10406)	Good catch.