Add virtual transaction size to the transaction description in Qt
ClosedPublic
Actions

Authored by deadalnix on Jul 11 2019, 19:57.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING9a3a34b08c19: Add virtual transaction size to the transaction description in Qt
rABC9a3a34b08c19: Add virtual transaction size to the transaction description in Qt

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

virtualsizetxdesc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6829
Build 11705: Bitcoin ABC Buildbot (legacy)
Build 11704: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 11 2019, 19:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2019, 19:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6829: Diff 10241.Jul 11 2019, 20:04

nakihito accepted this revision.Jul 15 2019, 22:33

This revision is now accepted and ready to land.Jul 15 2019, 22:33

Closed by commit rABC9a3a34b08c19: Add virtual transaction size to the transaction description in Qt (authored by deadalnix). · Explain WhyJul 15 2019, 22:48

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC9a3a34b08c19: Add virtual transaction size to the transaction description in Qt.

deadalnix added a commit: rSTAGING9a3a34b08c19: Add virtual transaction size to the transaction description in Qt.Sep 19 2019, 01:17

markblundeberg mentioned this in D4895: fix inappropriate uses of virtual size.Jan 11 2020, 09:20

Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC1196ec83ae81: fix inappropriate uses of virtual size.Jan 12 2020, 02:43

Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGING1196ec83ae81: fix inappropriate uses of virtual size.Apr 7 2020, 22:22

Revision Contents
Changeset List

Path

Size

src/

qt/

transactiondesc.cpp

4 lines

Diff 10241

View Options

src/qt/transactiondesc.cpp

Add virtual transaction size to the transaction description in QtClosedPublicActions