Page MenuHomePhabricator

[wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH
ClosedPublic

Authored by deadalnix on Jul 12 2019, 13:37.

Details

Summary

Only if -changetype is not set and -addresstype is not "legacy".

This is a backport of Core PR12119

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jul 12 2019, 13:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2019, 13:37

Why backport this? We haven't been supporting other address types (especially bech32).

src/wallet/wallet.cpp
3010 ↗(On Diff #10258)

iirc LearnRelatedScripts wasn't backported either.

jasonbcox accepted this revision.Jul 15 2019, 16:24

Talked about it offline. This isn't about backporting for usefulness, but rather paring down ownership on parts of the codebase that we do not want to own at this time.

This revision is now accepted and ready to land.Jul 15 2019, 16:24