[wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH
ClosedPublic
Actions

Talked about it offline. This isn't about backporting for usefulness, but rather paring down ownership on parts of the codebase that we do not want to own at this time.

This revision is now accepted and ready to land.Jul 15 2019, 16:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6835: Diff 10258.Jul 15 2019, 16:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC79fdaf1e1e25: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by deadalnix). · Explain WhyJul 15 2019, 19:20

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC79fdaf1e1e25: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH.

deadalnix added a commit: rSTAGING79fdaf1e1e25: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH.Sep 19 2019, 01:16

Revision Contents
Changeset List

			Path	Packages
M			src/qt/paymentserver.cpp (6 lines)
M			src/wallet/rpcwallet.cpp (6 lines)
M			src/wallet/wallet.h (2 lines)
M			src/wallet/wallet.cpp (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10258	059cdb9		Jul 12 2019, 13:36	★	★
Diff 2	10300	58bcb91	rABC79fdaf1e1e25c82f9f87a16796aea62e2cf47dde	Jul 15 2019, 19:20	★	★

Status	Author	Revision
Closed	deadalnix	D3670 [tests] [qt] Add tests for address book manipulation via EditAddressDialog
Closed	deadalnix	D3669 [qt] Display more helpful message when adding a send address has failed
Closed	deadalnix	D3668 Add purpose arg to Wallet::getAddress
Closed	deadalnix	D3666 [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage
Closed	deadalnix	D3665 wallet: Change output type globals to members
Closed	deadalnix	D3664 [qt] receive tab: bech32 address opt-in checkbox
Closed	deadalnix	D3663 Bech32 addresses in dumpwallet
Closed	deadalnix	D3662 [wallet] Add change type to CCoinControl
Closed	deadalnix	D3661 [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH