Page MenuHomePhabricator
Differential D3662

[wallet] Add change type to CCoinControl
ClosedPublic
Actions

Authored by deadalnix on Jul 12 2019, 15:15.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING7cead03ca992: [wallet] Add change type to CCoinControl
rABC7cead03ca992: [wallet] Add change type to CCoinControl
Summary

This is extracted from Core PR12194 . The rest of the PR is not interesting for us at this stage, but this part will avoid merge conflicts.

https://github.com/bitcoin/bitcoin/pull/12194/commits/31dbd5af4863d73c3215355ec5cf85bde2ddc5d8

Depends on D3661

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12194
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6836
Build 11719: Bitcoin ABC Buildbot (legacy)
Build 11718: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 12 2019, 15:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2019, 15:15
teamcity added a comment.Jul 12 2019, 15:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 12 2019, 15:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B6836: Diff 10259!Jul 12 2019, 15:21
deadalnix added a child revision: D3665: wallet: Change output type globals to members.Jul 12 2019, 17:15
teamcity added a comment.Jul 15 2019, 16:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Jul 15 2019, 16:33
This revision is now accepted and ready to land.Jul 15 2019, 16:33
teamcity added a comment.Jul 15 2019, 16:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6836: Diff 10259.Jul 15 2019, 16:39
Closed by commit rABC7cead03ca992: [wallet] Add change type to CCoinControl (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by deadalnix). · Explain WhyJul 15 2019, 19:24
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC7cead03ca992: [wallet] Add change type to CCoinControl.
deadalnix added a commit: rSTAGING7cead03ca992: [wallet] Add change type to CCoinControl.Sep 19 2019, 01:16

Revision Contents
Changeset List

PathSize
src/
wallet/
4 lines
1 line
3 lines
10 lines

Diff 10259

View Options

src/wallet/coincontrol.h

Loading...
View Options

src/wallet/coincontrol.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...