Page MenuHomePhabricator
Differential D3663

Bech32 addresses in dumpwallet
ClosedPublic
Actions

Authored by deadalnix on Jul 12 2019, 15:39.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING9a7c92d30b2c: Bech32 addresses in dumpwallet
rABC9a7c92d30b2c: Bech32 addresses in dumpwallet
Summary

Output bech32 addresses in dumpwallet if address type is not as legacy

This is a backport of Core PR12315 (without the Segwit bits).

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12315
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6837
Build 11721: Bitcoin ABC Buildbot (legacy)
Build 11720: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 12 2019, 15:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2019, 15:39
teamcity added a comment.Jul 12 2019, 15:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 12 2019, 15:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B6837: Diff 10260!Jul 12 2019, 15:41
deadalnix added a child revision: D3665: wallet: Change output type globals to members.Jul 12 2019, 17:15
teamcity added a comment.Jul 12 2019, 20:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 12 2019, 20:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6837: Diff 10260.Jul 12 2019, 20:53
jasonbcox accepted this revision.Jul 15 2019, 16:43
This revision is now accepted and ready to land.Jul 15 2019, 16:43
Closed by commit rABC9a7c92d30b2c: Bech32 addresses in dumpwallet (authored by fivepiece <fivepiece@users.noreply.github.com>, committed by deadalnix). · Explain WhyJul 15 2019, 17:57
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC9a7c92d30b2c: Bech32 addresses in dumpwallet.
deadalnix added a commit: rSTAGING9a7c92d30b2c: Bech32 addresses in dumpwallet.Sep 19 2019, 01:16

Revision Contents
Changeset List

PathSize
src/
wallet/
33 lines

Diff 10260

View Options

src/wallet/rpcdump.cpp

Loading...