Page MenuHomePhabricator
Differential D3665

wallet: Change output type globals to members
ClosedPublic
Actions

Authored by deadalnix on Jul 12 2019, 17:15.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING4ee17c4e7bd9: wallet: Change output type globals to members
rABC4ee17c4e7bd9: wallet: Change output type globals to members
Summary

This is a backport of Core PR12408

Depends on D3663, D3664 and D3662

Test Plan
make check
test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12408
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6839
Build 11725: Bitcoin ABC Buildbot (legacy)
Build 11724: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 12 2019, 17:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2019, 17:15
teamcity added a comment.Jul 12 2019, 17:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 12 2019, 17:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B6839: Diff 10264!Jul 12 2019, 17:21
deadalnix added a child revision: D3670: [tests] [qt] Add tests for address book manipulation via EditAddressDialog.Jul 12 2019, 18:24
teamcity added a comment.Jul 12 2019, 20:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 12 2019, 20:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6839: Diff 10264.Jul 12 2019, 20:51
jasonbcox accepted this revision.Jul 15 2019, 21:13
This revision is now accepted and ready to land.Jul 15 2019, 21:13
Closed by commit rABC4ee17c4e7bd9: wallet: Change output type globals to members (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyJul 15 2019, 22:41
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC4ee17c4e7bd9: wallet: Change output type globals to members.
deadalnix added a commit: rSTAGING4ee17c4e7bd9: wallet: Change output type globals to members.Sep 19 2019, 01:17

Revision Contents
Changeset List

PathSize
src/
interfaces/
3 lines
7 lines
qt/
2 lines
4 lines
5 lines
4 lines
test/
6 lines
wallet/
6 lines
2 lines
3 lines
4 lines
15 lines
test/
2 lines
5 lines
13 lines
30 lines

Diff 10264

View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/addresstablemodel.h

Loading...
View Options

src/qt/addresstablemodel.cpp

Loading...
View Options

src/qt/editaddressdialog.cpp

Loading...
View Options

src/qt/paymentserver.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/wallet/coincontrol.h

Loading...
View Options

src/wallet/coincontrol.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_test_fixture.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...