Page MenuHomePhabricator
Differential D3666

[tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage
ClosedPublic
Actions

Authored by deadalnix on Jul 12 2019, 17:48.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGaf857482f5aa: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage
rABCaf857482f5aa: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage
Summary

ConfirmMessage is reused in future tests apart from its single usage here.

This is a partial backport of Core PR12830 : https://github.com/bitcoin/bitcoin/pull/12830/commits/9c01be1b85f8ad11a8a0826a4a2bcdc2668a5c1f

Because ConfirmMessage was deleted - as we don't need it, it has to be recreated rather than moved. However, it is later used in PR12830 so we need it back.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
qttestutil
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6840
Build 11727: Bitcoin ABC Buildbot (legacy)
Build 11726: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 12 2019, 17:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2019, 17:48
teamcity added a comment.Jul 12 2019, 17:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 12 2019, 17:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6840: Diff 10266.Jul 12 2019, 17:57
deadalnix added a child revision: D3670: [tests] [qt] Add tests for address book manipulation via EditAddressDialog.Jul 12 2019, 18:24
jasonbcox accepted this revision.Jul 16 2019, 03:08
This revision is now accepted and ready to land.Jul 16 2019, 03:08
Closed by commit rABCaf857482f5aa: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage (authored by James O'Beirne <james.obeirne@gmail.com>, committed by deadalnix). · Explain WhyJul 16 2019, 13:01
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCaf857482f5aa: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage.
deadalnix added a commit: rSTAGINGaf857482f5aa: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage.Sep 19 2019, 01:17

Revision Contents
Changeset List

PathSize
src/
2 lines
qt/
test/
1 line
14 lines
20 lines
3 lines

Diff 10266

View Options

src/Makefile.qttest.include

Loading...
View Options

src/qt/test/CMakeLists.txt

Loading...
View Options

src/qt/test/util.h

Loading...
View Options

src/qt/test/util.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...