Page MenuHomePhabricator

[qt] Display more helpful message when adding a send address has failed
ClosedPublic

Authored by deadalnix on Jul 12 2019, 18:12.

Details

Summary

Addresses #12796.

When we're unable to add a sending address to the address book because it
already exists as a receiving address, display a message indicating as much.
This should help avoid confusion about an address supposedly already in the
book but which isn't currently visible in the interface.

This is a partial backport of Core PR12830 : https://github.com/bitcoin/bitcoin/pull/12830/commits/8cdcaee4c7b256c5c3b70f1cfb04a5fb547311cd

Depends on D3668

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
helpfulmessage
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6843
Build 11733: Bitcoin ABC Buildbot (legacy)
Build 11732: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 12 2019, 18:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2019, 18:12
jasonbcox accepted this revision.Jul 16 2019, 03:13
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/editaddressdialog.h
50

nit: comment style

This revision is now accepted and ready to land.Jul 16 2019, 03:13