Page MenuHomePhabricator

[tests] [qt] Add tests for address book manipulation via EditAddressDialog
ClosedPublic

Authored by deadalnix on Jul 12 2019, 18:24.

Details

Summary

Also modifies corresponding QT code to allow for use within test cases.

This is a partial backport of Core PR12830 : https://github.com/bitcoin/bitcoin/pull/12830/commits/5109fc4a9cb2cbd73c33197fb9129e1413ab051b

Depends on D3669, D3666 and D3665

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12830
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6844
Build 11735: Bitcoin ABC Buildbot (legacy)
Build 11734: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Jul 16 2019, 03:20
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/test/addressbooktests.cpp
2

Missing #include <qt/test/util.h> ? ConfirmMessage is used in this file, so it seems appropriate.

This revision now requires changes to proceed.Jul 16 2019, 03:20
deadalnix added inline comments.
src/qt/test/addressbooktests.cpp
11

...

This revision is now accepted and ready to land.Jul 16 2019, 21:50