Page MenuHomePhabricator
Differential D3670

[tests] [qt] Add tests for address book manipulation via EditAddressDialog
ClosedPublic
Actions

Authored by deadalnix on Jul 12 2019, 18:24.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING958bce8e47cb: [tests] [qt] Add tests for address book manipulation via EditAddressDialog
rABC958bce8e47cb: [tests] [qt] Add tests for address book manipulation via EditAddressDialog
Summary

Also modifies corresponding QT code to allow for use within test cases.

This is a partial backport of Core PR12830 : https://github.com/bitcoin/bitcoin/pull/12830/commits/5109fc4a9cb2cbd73c33197fb9129e1413ab051b

Depends on D3669, D3666 and D3665

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12830
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6844
Build 11735: Bitcoin ABC Buildbot (legacy)
Build 11734: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 12 2019, 18:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2019, 18:24
teamcity added a comment.Jul 12 2019, 18:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B6844: Diff 10271!Jul 12 2019, 18:26
teamcity added a comment.Jul 12 2019, 18:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

teamcity added a comment.Jul 16 2019, 03:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox requested changes to this revision.Jul 16 2019, 03:20
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/test/addressbooktests.cpp
2

Missing #include <qt/test/util.h> ? ConfirmMessage is used in this file, so it seems appropriate.

This revision now requires changes to proceed.Jul 16 2019, 03:20
Harbormaster completed remote builds in B6844: Diff 10271.Jul 16 2019, 03:20
teamcity added a comment.Jul 16 2019, 03:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix requested review of this revision.Jul 16 2019, 13:13
deadalnix added inline comments.
src/qt/test/addressbooktests.cpp
11

...

jasonbcox accepted this revision.Jul 16 2019, 21:50
This revision is now accepted and ready to land.Jul 16 2019, 21:50
Closed by commit rABC958bce8e47cb: [tests] [qt] Add tests for address book manipulation via EditAddressDialog (authored by James O'Beirne <james.obeirne@gmail.com>, committed by deadalnix). · Explain WhyJul 21 2019, 00:06
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC958bce8e47cb: [tests] [qt] Add tests for address book manipulation via EditAddressDialog.
deadalnix added a commit: rSTAGING958bce8e47cb: [tests] [qt] Add tests for address book manipulation via EditAddressDialog.Sep 19 2019, 01:20

Revision Contents
Changeset List

Diff 10271

View Options

src/Makefile.qttest.include

Loading...
View Options

src/qt/addressbookpage.h

Loading...
View Options

src/qt/editaddressdialog.h

Loading...
View Options

src/qt/test/CMakeLists.txt

Loading...
View Options

src/qt/test/addressbooktests.h

Loading...
View Options

src/qt/test/addressbooktests.cpp

Loading...
View Options

src/qt/test/test_main.cpp

Loading...
View Options

src/qt/walletmodel.h

Loading...