Page MenuHomePhabricator

[tests] [qt] Add tests for address book manipulation via EditAddressDialog
ClosedPublic

Authored by deadalnix on Jul 12 2019, 18:24.

Details

Summary

Also modifies corresponding QT code to allow for use within test cases.

This is a partial backport of Core PR12830 : https://github.com/bitcoin/bitcoin/pull/12830/commits/5109fc4a9cb2cbd73c33197fb9129e1413ab051b

Depends on D3669, D3666 and D3665

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12830
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6844
Build 11735: Bitcoin ABC Teamcity Staging
Build 11734: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 12 2019, 18:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2019, 18:24
jasonbcox requested changes to this revision.Jul 16 2019, 03:20
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/test/addressbooktests.cpp
2

Missing #include <qt/test/util.h> ? ConfirmMessage is used in this file, so it seems appropriate.

This revision now requires changes to proceed.Jul 16 2019, 03:20
deadalnix requested review of this revision.Jul 16 2019, 13:13
deadalnix added inline comments.
src/qt/test/addressbooktests.cpp
11

...

jasonbcox accepted this revision.Jul 16 2019, 21:50
This revision is now accepted and ready to land.Jul 16 2019, 21:50