Page MenuHomePhabricator

Merge #11495: [trivial] Make namespace explicit for is_regular_file
ClosedPublic

Authored by nakihito on Jul 16 2019, 23:34.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC4f6623155efe: Merge #11495: [trivial] Make namespace explicit for is_regular_file
Summary

f4c4e38 [trivial] Make namespace explicit for is_regular_file (John Newbery)

Pull request description:

is_regular_file resolves using argument dependent lookup. Make the
namespace explicit so it's obvious where the function is defined.

For those not familiar with argument dependent lookups:

- http://en.cppreference.com/w/cpp/language/adl
- https://en.wikipedia.org/wiki/Argument-dependent_name_lookup

Thanks to C++ guru @ryanofsky for pointing this out to me.

Tree-SHA512: 919f1818081a8f90c5751181f87e13b06d90f8aec0ab873100434e55c85cca6e0e288ecc7f135e19e9b5dba7952e96b6393864b7840e20b69dd40e92a157928b

Backport of Core PR11495
https://github.com/bitcoin/bitcoin/pull/11495/

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.