Page MenuHomePhabricator

Merge #11714: [tests] Test that mempool rejects coinbase transactions
ClosedPublic

Authored by nakihito on Jul 19 2019, 01:04.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCc314de9ab587: Merge #11714: [tests] Test that mempool rejects coinbase transactions
Summary

65e91f5ed [tests] Test that mempool rejects coinbase transactions (James O'Beirne)

Pull request description:

![selection_063](https://user-images.githubusercontent.com/73197/32978622-b0fa9d70-cbfa-11e7-9a72-1997409e5ba8.png)

Neither the unit nor functional tests appear to cover rejecting a transaction from acceptance to the mempool on the basis of it being a coinbase. Seems like a decent thing to have a test for.

Tree-SHA512: 53af53c975cad5d7a21c443d71a1c0ced5c70a7799b75bb44d9b7dd6ab2afbcdcaab14571540efeb848f3a1daee5e1dd856530d8f2b50582595219a1c17555ff

Backport of Core PR11714
https://github.com/bitcoin/bitcoin/pull/11714/

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Jul 19 2019, 01:04
Owners added a reviewer: Restricted Owners Package.Jul 19 2019, 01:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 19 2019, 01:04
nakihito planned changes to this revision.Jul 19 2019, 01:04
nakihito added inline comments.Jul 19 2019, 01:05
src/test/txvalidation_tests.cpp
53 ↗(On Diff #10353)
nakihito edited the test plan for this revision. (Show Details)Jul 19 2019, 01:06
nakihito requested review of this revision.Jul 19 2019, 17:34
deadalnix accepted this revision.Jul 20 2019, 00:09
This revision is now accepted and ready to land.Jul 20 2019, 00:09