Page MenuHomePhabricator
Differential D3700

Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction
ClosedPublic
Actions

Authored by jasonbcox on Jul 19 2019, 23:34.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf380cead5ef1: Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction
rABCf380cead5ef1: Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction
Summary

37495e0d8 Reorder C{,Mutable}Transaction for better packing (Jeremy Rubin)

Pull request description:

These commits revise the layout of a few key classes to eliminate padding, eliminating useless memory overhead.

-This reduces CTransaction from 96 bytes to 88 bytes

Tree-SHA512: 91d1fec363edebbb1f1a5b98142c767511e99d3be857148a76e31cc512c9ab3d153083fa6b46b6407974d3b88de984b436c33e8606fbb2b273d74c825195aa17

Backport of Core PR8330
https://github.com/bitcoin/bitcoin/pull/8330/files

Test Plan
make check
gdb bitcoind
gdb> print sizeof(CTransaction)
  # Before patch: 96
  # After patch: 88
gdb> print sizeof(CMutableTransaction)
  # Before patch: 64
  # After patch: 56

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 19 2019, 23:34
Herald added a reviewer: deadalnix. · View Herald TranscriptJul 19 2019, 23:34
teamcity added a comment.Jul 19 2019, 23:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 19 2019, 23:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6894: Diff 10362.Jul 19 2019, 23:45
deadalnix requested changes to this revision.Jul 20 2019, 00:01

The test plan can be automated at compile time.

This revision now requires changes to proceed.Jul 20 2019, 00:01
jasonbcox updated this revision to Diff 10409.Jul 23 2019, 19:26

Added static assertions to check sizes at compile time

teamcity added a comment.Jul 23 2019, 19:27

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 23 2019, 19:37

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6924: Diff 10409.Jul 23 2019, 19:37
deadalnix requested changes to this revision.Jul 24 2019, 13:17
deadalnix added inline comments.
src/primitives/transaction.h
295 ↗(On Diff #10409)

Don't use yoda style.

336 ↗(On Diff #10409)

dito

This revision now requires changes to proceed.Jul 24 2019, 13:17
jasonbcox updated this revision to Diff 10434.Jul 24 2019, 15:49

Feedback

teamcity added a comment.Jul 24 2019, 15:49

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 24 2019, 16:00

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6942: Diff 10434.Jul 24 2019, 16:00
deadalnix accepted this revision.Jul 24 2019, 17:18
This revision is now accepted and ready to land.Jul 24 2019, 17:18
Closed by commit rABCf380cead5ef1: Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyJul 24 2019, 17:23
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCf380cead5ef1: Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction.
jasonbcox mentioned this in D3730: Restrict CTransaction size assertion to x86.Jul 24 2019, 20:00
jasonbcox mentioned this in rABC90d399fa8d9f: Restrict CTransaction size assertion to x86.Jul 24 2019, 23:50
jasonbcox added a commit: rSTAGINGf380cead5ef1: Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction.Sep 19 2019, 01:24
jasonbcox mentioned this in rSTAGING90d399fa8d9f: Restrict CTransaction size assertion to x86.

Revision Contents
Changeset List

PathSize
src/
primitives/
6 lines
8 lines

Diff 10438

View Options

src/primitives/transaction.h

Loading...
View Options

src/primitives/transaction.cpp

Loading...