Page MenuHomePhabricator

Migrate build configs from TeamCity to build-configurations.sh
ClosedPublic

Authored by jasonbcox on Jul 22 2019, 18:06.

Details

Summary

This provides the following benefits:

  1. Build configs under source control.
  2. TeamCity admins are no longer the sole owners of build configs.
  3. New diff build configs can be modified/created and tested without requiring manual intervention by TeamCity admins. All that is needed is a build bot that listens for a build config name on Phab diffs.
  4. Reduced maintenance overhead due to de-duplicating build configs. Our current infra requires manually adding a new build config via TeamCity for every type of build we want to run on diffs. This is separate from the identical builds used for other purposes (ie. master, IBD). Keeping all of these configs up-to-date with eachother is unnecessary.
Test Plan

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove set -u as it's unnecessary and prevents showing a useful error message

Fix: Needs to be able to be run from different directories

jasonbcox edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jul 22 2019, 19:20
Fabien requested changes to this revision.Jul 22 2019, 19:53
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/teamcity/build-configurations.sh
17 ↗(On Diff #10379)

The ASAN_OPTIONS will be overriden by the build script.
You can whether move all the options here or just drop this line (I think malloc_context_size=0 is no longer needed with lsan suppression file, but I will check).

This revision now requires changes to proceed.Jul 22 2019, 19:53
contrib/teamcity/build-configurations.sh
17 ↗(On Diff #10379)

I'll rerun the ASAN build with this line removed to be sure.

Remove ASAN_OPTIONS as it's no longer needed.

This revision is now accepted and ready to land.Jul 22 2019, 20:35