This provides the following benefits:
- Build configs under source control.
- TeamCity admins are no longer the sole owners of build configs.
- New diff build configs can be modified/created and tested without requiring manual intervention by TeamCity admins. All that is needed is a build bot that listens for a build config name on Phab diffs.
- Reduced maintenance overhead due to de-duplicating build configs. Our current infra requires manually adding a new build config via TeamCity for every type of build we want to run on diffs. This is separate from the identical builds used for other purposes (ie. master, IBD). Keeping all of these configs up-to-date with eachother is unnecessary.