HomePhabricator

Migrate build configs from TeamCity to build-configurations.sh

Description

Migrate build configs from TeamCity to build-configurations.sh

Summary:
This provides the following benefits:

  1. Build configs under source control.
  2. TeamCity admins are no longer the sole owners of build configs.
  3. New diff build configs can be modified/created and tested without requiring manual intervention by TeamCity admins. All that is needed is a build bot that listens for a build config name on Phab diffs.
  4. Reduced maintenance overhead due to de-duplicating build configs. Our current infra requires manually adding a new build config via TeamCity for every type of build we want to run on diffs. This is separate from the identical builds used for other purposes (ie. master, IBD). Keeping all of these configs up-to-date with eachother is unnecessary.

Test Plan:
Each build will be executed by the same TeamCity config of the form:
ABC_BUILD_NAME=<config name> ./build-configurations.sh
ABC_BUILD_NAME will be provided at runtime.
Default build: https://build.bitcoinabc.org/viewLog.html?buildId=16818&buildTypeId=BitcoinABC_Staging_BitcoinAbcDiffTestingMigrationWip&tab=buildParameters
Build without wallet: https://build.bitcoinabc.org/viewLog.html?buildId=16820&buildTypeId=BitcoinABC_Staging_BitcoinAbcDiffTestingMigrationWip&tab=buildParameters
ASAN: https://build.bitcoinabc.org/viewLog.html?buildId=16819&buildTypeId=BitcoinABC_Staging_BitcoinAbcDiffTestingMigrationWip&tab=buildParameters

The script was also run with ABC_BUILD_NAME not set: https://build.bitcoinabc.org/viewLog.html?buildId=16813&buildTypeId=BitcoinABC_Staging_BitcoinAbcDiffTestingMigrationWip&tab=buildLog

Reviewers: #bitcoin_abc, deadalnix, Fabien

Reviewed By: #bitcoin_abc, deadalnix, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D3706

Details

Provenance
jasonbcoxAuthored on Jul 22 2019, 17:45
nakihitoPushed on Jul 22 2019, 23:24
Reviewer
Restricted Project
Differential Revision
D3706: Migrate build configs from TeamCity to build-configurations.sh
Parents
rSTAGINGb8cbd5598fdc: Merge #11997: [tests] util_tests.cpp: actually check ignored args
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/10391