Page MenuHomePhabricator

Use a struct for arguments and nested map for categories
ClosedPublic

Authored by deadalnix on Jul 23 2019, 00:04.

Details

Summary

Instead of a single map with the category and name as the key,
make m_available_args contain maps. The key will be the category and
the value is a map which actually contains the arguments for that
category. The nested map's key is the argument name, while the value
is a struct that contains the help text and whether the argument is
a debug only argument.

This is a partial backport of Core PR13112 : https://github.com/bitcoin/bitcoin/pull/13112/commits/174f7c80801383cde5ea514b19fb8b108b56b31c

The hidden parameter cathegory has been added because it doesn't build without it - this also the case in the original PR.

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13112
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6914
Build 11875: Bitcoin ABC Buildbot (legacy)
Build 11874: arc lint + arc unit