Make ScriptError a C++11 first class enum
ClosedPublic
Actions

Authored by deadalnix on Jul 24 2019, 21:09.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGdba8abb52c07: Make ScriptError a C++11 first class enum
rABCdba8abb52c07: Make ScriptError a C++11 first class enum

Summary

We are now using C++11, so let's use it.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

scripterror

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6948
Build 11943: Bitcoin ABC Buildbot (legacy)
Build 11942: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 24 2019, 21:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 24 2019, 21:09

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6948: Diff 10446.Jul 24 2019, 21:17

The rest looks good.

src/script/script_error.h
81	This doesn't appear to be used in our code or Core's. Probably best to remove it.

This revision now requires changes to proceed.Jul 24 2019, 22:05

deadalnix requested review of this revision.Jul 24 2019, 23:40

deadalnix added inline comments.

src/script/script_error.h
81	This is completely unrelated to what the diff is doing.

jasonbcox accepted this revision.Jul 24 2019, 23:56

This revision is now accepted and ready to land.Jul 24 2019, 23:56

Closed by commit rABCdba8abb52c07: Make ScriptError a C++11 first class enum (authored by deadalnix). · Explain WhyJul 25 2019, 00:01

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCdba8abb52c07: Make ScriptError a C++11 first class enum.

deadalnix added a commit: rSTAGINGdba8abb52c07: Make ScriptError a C++11 first class enum.Sep 19 2019, 01:25

Revision Contents
Changeset List

Path

Size

src/

rpc/

rawtransaction.cpp

4 lines

script/

191 lines

100 lines

92 lines

18 lines

test/

checkdatasig_tests.cpp

72 lines

monolith_opcodes_tests.cpp

122 lines

multisig_tests.cpp

16 lines

schnorr_tests.cpp

42 lines

script_p2sh_tests.cpp

9 lines

script_tests.cpp

339 lines

sigencoding_tests.cpp

56 lines

sigopcount_tests.cpp

12 lines

transaction_tests.cpp

10 lines

validation.h

4 lines

Diff 10446

View Options

src/rpc/rawtransaction.cpp

View Options

src/script/interpreter.cpp

View Options

src/script/script_error.h

View Options

src/script/script_error.cpp

View Options

src/script/sigencoding.cpp

View Options

src/test/checkdatasig_tests.cpp

View Options

src/test/monolith_opcodes_tests.cpp

View Options

src/test/multisig_tests.cpp

View Options

src/test/schnorr_tests.cpp

View Options

src/test/script_p2sh_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/sigencoding_tests.cpp

View Options

src/test/sigopcount_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

Make ScriptError a C++11 first class enumClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10446

src/rpc/rawtransaction.cpp

src/script/interpreter.cpp

src/script/script_error.h

src/script/script_error.cpp

src/script/sigencoding.cpp

src/test/checkdatasig_tests.cpp

src/test/monolith_opcodes_tests.cpp

src/test/multisig_tests.cpp

src/test/schnorr_tests.cpp

src/test/script_p2sh_tests.cpp

src/test/script_tests.cpp

src/test/sigencoding_tests.cpp

src/test/sigopcount_tests.cpp

src/test/transaction_tests.cpp

src/validation.h

Make ScriptError a C++11 first class enum
ClosedPublic
Actions

Revision Contents
Changeset List