Page MenuHomePhabricator
Differential D3733

Merge #12545: test: Use wait_until to ensure ping goes out
ClosedPublic
Actions

Authored by jasonbcox on Jul 24 2019, 22:55.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGc1776d323e08: Merge #12545: test: Use wait_until to ensure ping goes out
rABCc1776d323e08: Merge #12545: test: Use wait_until to ensure ping goes out
Summary

0eb84f30d8 test: Use wait_until to ensure ping goes out (Ben Woosley)

Pull request description:

Intermittent failure evident here:
https://travis-ci.org/bitcoin/bitcoin/jobs/344021180

Tree-SHA512: 8d3cbc55563160390d3918eb0b22348990cd81ad35c0563033f19142cb43b86a150fecc7df2196209ba00aaa805c67285451e582f387f8dac22d5e44d54e8a0d

Backport of Core PR12545
https://github.com/bitcoin/bitcoin/pull/12545/files

Test Plan

test_runner.py rpc_net

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 24 2019, 22:55
Herald added a reviewer: deadalnix. · View Herald TranscriptJul 24 2019, 22:55
teamcity added a comment.Jul 24 2019, 22:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 24 2019, 23:06

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6950: Diff 10448.Jul 24 2019, 23:06
Fabien accepted this revision.Jul 25 2019, 07:34
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/rpc_net.py
52 ↗(On Diff #10448)

Nit: spaces 32 * 2

54 ↗(On Diff #10448)

Dito

This revision is now accepted and ready to land.Jul 25 2019, 07:34
jasonbcox updated this revision to Diff 10475.Jul 25 2019, 16:11

Fix nits

teamcity added a comment.Jul 25 2019, 16:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 25 2019, 16:19

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B6966: Diff 10475!Jul 25 2019, 16:19
teamcity added a comment.Jul 25 2019, 16:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 25 2019, 16:45

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6966: Diff 10475.Jul 25 2019, 16:45
Closed by commit rABCc1776d323e08: Merge #12545: test: Use wait_until to ensure ping goes out (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyJul 25 2019, 17:06
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCc1776d323e08: Merge #12545: test: Use wait_until to ensure ping goes out.
jasonbcox added a commit: rSTAGINGc1776d323e08: Merge #12545: test: Use wait_until to ensure ping goes out.Sep 19 2019, 01:27

Revision Contents
Changeset List

PathSize
test/
functional/
12 lines

Diff 10481

View Options

test/functional/rpc_net.py

Loading...