Page MenuHomePhabricator
Differential D3735

Add a facility to parse and validate script bitfields.
ClosedPublic
Actions

Authored by deadalnix on Jul 25 2019, 01:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING9364c3a392e7: Add a facility to parse and validate script bitfields.
rABC9364c3a392e7: Add a facility to parse and validate script bitfields.
Summary

As per title. Bitfield are little endian and has a size proportional to the number of bits they represent. The decoder validates that there are no out of bound bits.

Test Plan

Added unit tests.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
scriptfitfield
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6958
Build 11963: Bitcoin ABC Buildbot (legacy)
Build 11962: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 25 2019, 01:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2019, 01:53
teamcity added a comment.Jul 25 2019, 01:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 25 2019, 01:55

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B6954: Diff 10458!Jul 25 2019, 01:55
deadalnix updated this revision to Diff 10459.Jul 25 2019, 02:01

Add error messages

teamcity added a comment.Jul 25 2019, 02:01

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 25 2019, 02:02

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B6955: Diff 10459!Jul 25 2019, 02:02
Fabien requested changes to this revision.Jul 25 2019, 07:32
Fabien added a subscriber: Fabien.

The build is failing

src/script/bitfield.cpp
11 ↗(On Diff #10459)

Why do you need size to be signed ?

src/script/bitfield.h
13 ↗(On Diff #10459)

count => size

This revision now requires changes to proceed.Jul 25 2019, 07:32
deadalnix added inline comments.Jul 25 2019, 10:35
src/script/bitfield.cpp
11 ↗(On Diff #10459)

Clearly, no.

deadalnix updated this revision to Diff 10465.Jul 25 2019, 10:38

Make the size unsigned.
count => size

teamcity added a comment.Jul 25 2019, 10:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 25 2019, 10:40

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B6958: Diff 10465!Jul 25 2019, 10:40
deadalnix updated this revision to Diff 10466.Jul 25 2019, 10:59

Include stddef to get size_t

teamcity added a comment.Jul 25 2019, 10:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 25 2019, 11:09

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B6959: Diff 10466!Jul 25 2019, 11:09
Fabien accepted this revision.Jul 25 2019, 11:42
This revision is now accepted and ready to land.Jul 25 2019, 11:42
This revision was landed with ongoing or failed builds.Jul 25 2019, 13:21
Closed by commit rABC9364c3a392e7: Add a facility to parse and validate script bitfields. (authored by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC9364c3a392e7: Add a facility to parse and validate script bitfields..
deadalnix added a commit: rSTAGING9364c3a392e7: Add a facility to parse and validate script bitfields..Sep 19 2019, 01:26

Revision Contents
Changeset List

Diff 10465

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/Makefile.test.include

Loading...
View Options

src/script/bitfield.h

Loading...
View Options

src/script/bitfield.cpp

Loading...
View Options

src/script/script_error.h

Loading...
View Options

src/script/script_error.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/script_bitfield_tests.cpp

Loading...