Page MenuHomePhabricator

[CI] Enable the undefined behaviour sanitizer
ClosedPublic

Authored by Fabien on Jul 25 2019, 21:26.

Details

Summary

This diff enables UBSAN build.
It requires running with clang as UBSAN support in gcc is very poor (at
least until most recent versions ; in particular it won't run on Debian
9 which is our current CI target).

Test Plan

Run the CI build-ubsan config.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
teamcity_ubsan_enable
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6975
Build 11997: Bitcoin ABC Buildbot (legacy)
Build 11996: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Jul 25 2019, 21:38
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
contrib/teamcity/build-configurations.sh
16

If we're going to run these together, then this should be renamed.

This revision now requires changes to proceed.Jul 25 2019, 21:38

Rename the build to include ubsan.

contrib/teamcity/build-configurations.sh
17 ↗(On Diff #10498)

It's probably preferable to run them together and have 2 builds instead, no?

Separate build-ubsan from build-asan.

Fabien edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Aug 5 2019, 17:01