Page MenuHomePhabricator
Differential D3749

[CI] Enable the undefined behaviour sanitizer
ClosedPublic
Actions

Authored by Fabien on Jul 25 2019, 21:26.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING7e560769acbe: [CI] Enable the undefined behaviour sanitizer
rABC7e560769acbe: [CI] Enable the undefined behaviour sanitizer
Summary

This diff enables UBSAN build.
It requires running with clang as UBSAN support in gcc is very poor (at
least until most recent versions ; in particular it won't run on Debian
9 which is our current CI target).

Test Plan

Run the CI build-ubsan config.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
teamcity_ubsan_enable
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6975
Build 11997: Bitcoin ABC Buildbot (legacy)
Build 11996: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 25 2019, 21:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2019, 21:26
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 25 2019, 21:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 25 2019, 21:35

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6975: Diff 10495.Jul 25 2019, 21:35
jasonbcox requested changes to this revision.Jul 25 2019, 21:38
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
contrib/teamcity/build-configurations.sh
16

If we're going to run these together, then this should be renamed.

This revision now requires changes to proceed.Jul 25 2019, 21:38
teamcity added a comment.Jul 26 2019, 07:21

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 26 2019, 07:37

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien added a comment.Jul 26 2019, 08:18

Test passed on CI

Fabien updated this revision to Diff 10498.Jul 26 2019, 08:19

Rename the build to include ubsan.

teamcity added a comment.Jul 26 2019, 08:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B6978: Diff 10498.Jul 26 2019, 08:25
teamcity added a comment.Jul 26 2019, 08:25

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix added inline comments.Jul 26 2019, 13:31
contrib/teamcity/build-configurations.sh
17 ↗(On Diff #10498)

It's probably preferable to run them together and have 2 builds instead, no?

Fabien updated this revision to Diff 10615.Aug 5 2019, 16:41

Separate build-ubsan from build-asan.

teamcity added a comment.Aug 5 2019, 16:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 5 2019, 16:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien edited the summary of this revision. (Show Details)Aug 5 2019, 16:45
Fabien edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B7046: Diff 10615.Aug 5 2019, 16:47
teamcity added a comment.Aug 5 2019, 16:47

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Aug 5 2019, 16:56

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox accepted this revision.Aug 5 2019, 17:01
This revision is now accepted and ready to land.Aug 5 2019, 17:01
Closed by commit rABC7e560769acbe: [CI] Enable the undefined behaviour sanitizer (authored by Fabien). · Explain WhyAug 6 2019, 08:59
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC7e560769acbe: [CI] Enable the undefined behaviour sanitizer.
Fabien added a commit: rSTAGING7e560769acbe: [CI] Enable the undefined behaviour sanitizer.Sep 19 2019, 01:38

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
2 lines

Diff 10495

View Options

contrib/teamcity/build-configurations.sh

Loading...