Refactor: RPC: Separate GetBlockChecked() from getblock()
ClosedPublic
Actions

Authored by Fabien on Jul 29 2019, 10:31.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGa96b5ee6234b: Refactor: RPC: Separate GetBlockChecked() from getblock()
rABCa96b5ee6234b: Refactor: RPC: Separate GetBlockChecked() from getblock()

Summary

This does not change functionality

Partial backport of core PR10757 (commit cda8e36)
https://github.com/bitcoin/bitcoin/pull/10757/commits/cda8e36f019dd181e5c3774961b4f1335e5602cb

Test Plan

make check
./test/functional/test_runner.py rpc_blockchain

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 29 2019, 10:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 29 2019, 10:31

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D3756: RPC: Introduce getblockstats to plot things.Jul 29 2019, 10:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6985: Diff 10509.Jul 29 2019, 10:37

deadalnix accepted this revision.Aug 1 2019, 06:11

This revision is now accepted and ready to land.Aug 1 2019, 06:11

Closed by commit rABCa96b5ee6234b: Refactor: RPC: Separate GetBlockChecked() from getblock() (authored by Jorge Timón <jtimon@jtimon.cc>, committed by Fabien). · Explain WhyAug 1 2019, 09:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa96b5ee6234b: Refactor: RPC: Separate GetBlockChecked() from getblock().

Fabien added a commit: rSTAGINGa96b5ee6234b: Refactor: RPC: Separate GetBlockChecked() from getblock().Sep 19 2019, 01:31

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

33 lines

Diff 10559

View Options

Refactor: RPC: Separate GetBlockChecked() from getblock()ClosedPublicActions