Page MenuHomePhabricator
Differential D3759

[tests] Make rpcauth.py testable and add unit tests
ClosedPublic
Actions

Authored by Fabien on Jul 29 2019, 15:43.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGe760b402e979: [tests] Make rpcauth.py testable and add unit tests
rABCe760b402e979: [tests] Make rpcauth.py testable and add unit tests
Summary

Backport of core PR13056 and PR13073
https://github.com/bitcoin/bitcoin/pull/13056/files
https://github.com/bitcoin/bitcoin/pull/13073/files

Depends on D3758.

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 29 2019, 15:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 29 2019, 15:43
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 29 2019, 15:44

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 29 2019, 15:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6989: Diff 10515.Jul 29 2019, 15:50
Fabien added a child revision: D3772: Add linter: Make sure we explicitly open all text files using UTF-8.Jul 30 2019, 18:18
Fabien added a child revision: D3780: rpcauth: Make it possible to provide a custom password.Jul 31 2019, 08:15
Fabien updated this revision to Diff 10544.Jul 31 2019, 13:02

Add cmake support.

Fabien edited the test plan for this revision. (Show Details)Jul 31 2019, 13:02
teamcity added a comment.Jul 31 2019, 13:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7016: Diff 10544.Jul 31 2019, 13:08
teamcity added a comment.Jul 31 2019, 13:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix requested changes to this revision.Aug 1 2019, 06:16
deadalnix added inline comments.
Makefile.am
266 ↗(On Diff #10544)

There is something wrong here.

test/CMakeLists.txt
83 ↗(On Diff #10544)

Remove -test

This revision now requires changes to proceed.Aug 1 2019, 06:16
Fabien updated this revision to Diff 10558.Aug 1 2019, 09:40

Fix space vs tab indent.
Rename the target to avoid the redondant check-test pattern.

teamcity added a comment.Aug 1 2019, 09:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7025: Diff 10558.Aug 1 2019, 09:47
teamcity added a comment.Aug 1 2019, 09:47

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix added inline comments.Aug 3 2019, 07:24
test/CMakeLists.txt
55 ↗(On Diff #10558)

This is clearly doesn't happen in the autotool build.

90 ↗(On Diff #10558)

Why does this need to be executed in the binary dir?

Fabien added inline comments.Aug 3 2019, 19:53
test/CMakeLists.txt
55 ↗(On Diff #10558)

There is an equivalent AC_CONFIG_LINKS for autotools (see above).

90 ↗(On Diff #10558)

rpcauth-test.py requires the config.ini file to be located at ../config.ini, and this file is generated to the build tree rather than the source tree.

deadalnix accepted this revision.Aug 4 2019, 07:57
This revision is now accepted and ready to land.Aug 4 2019, 07:57
Closed by commit rABCe760b402e979: [tests] Make rpcauth.py testable and add unit tests (authored by Qasim Javed <qasimj@gmail.com>, committed by Fabien). · Explain WhyAug 5 2019, 06:59
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe760b402e979: [tests] Make rpcauth.py testable and add unit tests.
Fabien added a commit: rSTAGINGe760b402e979: [tests] Make rpcauth.py testable and add unit tests.Sep 19 2019, 01:34

Revision Contents
Changeset List

PathSize
3 lines
1 line
share/
rpcauth/
55 lines
src/
2 lines
test/
16 lines
util/
51 lines

Diff 10583

View Options

Makefile.am

Loading...
View Options

configure.ac

Loading...
View Options

share/rpcauth/rpcauth.py

Loading...
View Options

src/Makefile.test.include

Loading...
View Options

test/CMakeLists.txt

Loading...
View Options

test/util/rpcauth-test.py

Loading...