Page MenuHomePhabricator

[tests] Make rpcauth.py testable and add unit tests
ClosedPublic

Authored by Fabien on Jul 29 2019, 15:43.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jul 29 2019, 15:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 29 2019, 15:43
Fabien updated this revision to Diff 10544.Jul 31 2019, 13:02

Add cmake support.

Fabien edited the test plan for this revision. (Show Details)Jul 31 2019, 13:02
deadalnix requested changes to this revision.Aug 1 2019, 06:16
deadalnix added inline comments.
Makefile.am
266 ↗(On Diff #10544)

There is something wrong here.

test/CMakeLists.txt
83 ↗(On Diff #10544)

Remove -test

This revision now requires changes to proceed.Aug 1 2019, 06:16
Fabien updated this revision to Diff 10558.Aug 1 2019, 09:40

Fix space vs tab indent.
Rename the target to avoid the redondant check-test pattern.

deadalnix added inline comments.Aug 3 2019, 07:24
test/CMakeLists.txt
55 ↗(On Diff #10558)

This is clearly doesn't happen in the autotool build.

90 ↗(On Diff #10558)

Why does this need to be executed in the binary dir?

Fabien added inline comments.Aug 3 2019, 19:53
test/CMakeLists.txt
55 ↗(On Diff #10558)

There is an equivalent AC_CONFIG_LINKS for autotools (see above).

90 ↗(On Diff #10558)

rpcauth-test.py requires the config.ini file to be located at ../config.ini, and this file is generated to the build tree rather than the source tree.

deadalnix accepted this revision.Aug 4 2019, 07:57
This revision is now accepted and ready to land.Aug 4 2019, 07:57
This revision was automatically updated to reflect the committed changes.