Page MenuHomePhabricator

[tests] Make rpcauth.py testable and add unit tests
ClosedPublic

Authored by Fabien on Jul 29 2019, 15:43.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13056
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6989
Build 12025: Bitcoin ABC Buildbot (legacy)
Build 12024: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Aug 1 2019, 06:16
deadalnix added inline comments.
Makefile.am
266 ↗(On Diff #10544)

There is something wrong here.

test/CMakeLists.txt
83 ↗(On Diff #10544)

Remove -test

This revision now requires changes to proceed.Aug 1 2019, 06:16

Fix space vs tab indent.
Rename the target to avoid the redondant check-test pattern.

test/CMakeLists.txt
55 ↗(On Diff #10558)

This is clearly doesn't happen in the autotool build.

90 ↗(On Diff #10558)

Why does this need to be executed in the binary dir?

test/CMakeLists.txt
55 ↗(On Diff #10558)

There is an equivalent AC_CONFIG_LINKS for autotools (see above).

90 ↗(On Diff #10558)

rpcauth-test.py requires the config.ini file to be located at ../config.ini, and this file is generated to the build tree rather than the source tree.

This revision is now accepted and ready to land.Aug 4 2019, 07:57