Use the existing config in CreateAndProcessBlock
ClosedPublic
Actions

Authored by jasonbcox on Jul 30 2019, 22:53.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING11fdc11dc566: Use the existing config in CreateAndProcessBlock
rABC11fdc11dc566: Use the existing config in CreateAndProcessBlock

Summary

GetConfig() is already called in this function. There's no reason to call it twice.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

configcleanup

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7006
Build 12059: Bitcoin ABC Buildbot (legacy)
Build 12058: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 30 2019, 22:53

Herald added a reviewer: deadalnix. · View Herald TranscriptJul 30 2019, 22:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7006: Diff 10534.Jul 30 2019, 22:59

Fabien accepted this revision.Jul 31 2019, 06:54

This revision is now accepted and ready to land.Jul 31 2019, 06:54

Closed by commit rABC11fdc11dc566: Use the existing config in CreateAndProcessBlock (authored by jasonbcox). · Explain WhyAug 2 2019, 17:06

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC11fdc11dc566: Use the existing config in CreateAndProcessBlock.

jasonbcox added a commit: rSTAGING11fdc11dc566: Use the existing config in CreateAndProcessBlock.Sep 19 2019, 01:33

Revision Contents
Changeset List

Path

Size

src/

test/

test_bitcoin.cpp

2 lines

Diff 10534

View Options

Use the existing config in CreateAndProcessBlockClosedPublicActions