Remove dead code in BasicTestingSetup
ClosedPublic
Actions

Authored by jasonbcox on Jul 30 2019, 22:55.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGdc6a184ba0b5: Remove dead code in BasicTestingSetup
rABCdc6a184ba0b5: Remove dead code in BasicTestingSetup

Summary

This config is now unused. It was originally added to clear state between tests, but block size is no longer a global variable, so this code does nothing.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

configcleanup2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7007
Build 12061: Bitcoin ABC Buildbot (legacy)
Build 12060: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 30 2019, 22:55

Herald added a reviewer: deadalnix. · View Herald TranscriptJul 30 2019, 22:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7007: Diff 10535.Jul 30 2019, 23:01

jasonbcox edited the summary of this revision. (Show Details)Jul 30 2019, 23:07

Fabien accepted this revision.Jul 31 2019, 06:57

This revision is now accepted and ready to land.Jul 31 2019, 06:57

Closed by commit rABCdc6a184ba0b5: Remove dead code in BasicTestingSetup (authored by jasonbcox). · Explain WhyAug 2 2019, 17:24

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCdc6a184ba0b5: Remove dead code in BasicTestingSetup.

jasonbcox added a commit: rSTAGINGdc6a184ba0b5: Remove dead code in BasicTestingSetup.Sep 19 2019, 01:33

Revision Contents
Changeset List

Path

Size

src/

test/

test_bitcoin.cpp

4 lines

Diff 10535

View Options

Remove dead code in BasicTestingSetupClosedPublicActions