Merge #11753: clarify abortrescan rpc use
ClosedPublic
Actions

Authored by nakihito on Jul 31 2019, 00:49.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGeb79705ccc5d: Merge #11753: clarify abortrescan rpc use
rABCeb79705ccc5d: Merge #11753: clarify abortrescan rpc use

Summary

8b2c733 clarify abortrescan rpc use (Gregory Sanders)

Pull request description:

`-rescan` during startup doesn't apply since RPC has not warmed up by that point

Tree-SHA512: 0b6738ed9429ca41edbfa23bb3e2da23bb16fed9e55c1803ab140b2efc49ef3295bb8b7eeb8c24df94204c5b3fb25d0d57cbc8d1be11856a5763c9fde71bceba

Backport of Core PR11753
https://github.com/bitcoin/bitcoin/pull/11753/

Test Plan

make check
./bitcoind
./bitcoin-cli help abortrescan

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Jul 31 2019, 00:49

Owners added a reviewer: Restricted Owners Package.Jul 31 2019, 00:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2019, 00:49

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7008: Diff 10536.Jul 31 2019, 00:56

Fabien accepted this revision.Jul 31 2019, 06:59

This revision is now accepted and ready to land.Jul 31 2019, 06:59

Closed by commit rABCeb79705ccc5d: Merge #11753: clarify abortrescan rpc use (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJul 31 2019, 18:18

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCeb79705ccc5d: Merge #11753: clarify abortrescan rpc use.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGeb79705ccc5d: Merge #11753: clarify abortrescan rpc use.Sep 19 2019, 01:30

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcdump.cpp

4 lines

Diff 10554

View Options

Merge #11753: clarify abortrescan rpc useClosedPublicActions