Merge #11889: Drop extra script variable in ProduceSignature
ClosedPublic
Actions

Authored by nakihito on Jul 31 2019, 19:43.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING9bef8b2b85de: Merge #11889: Drop extra script variable in ProduceSignature
rABC9bef8b2b85de: Merge #11889: Drop extra script variable in ProduceSignature

Summary

9360f5032 Drop extra script variable in ProduceSignature (Russell Yanofsky)

Pull request description:

Was slightly confusing.

Tree-SHA512: 1d18f92c133772ffc8eb71826c8d778988839a14bcefc50f9c591111b0a5f81ebc12bca0f1ab25d5fdd02d3d50c2325c04cbfcbdcd18a7b80ca112d049c2327d

Backport of Core PR11889
https://github.com/bitcoin/bitcoin/pull/11889/

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Jul 31 2019, 19:43

Owners added a reviewer: Restricted Owners Package.Jul 31 2019, 19:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2019, 19:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7024: Diff 10556.Jul 31 2019, 19:53

Fabien accepted this revision.Jul 31 2019, 20:30

This revision is now accepted and ready to land.Jul 31 2019, 20:30

Closed by commit rABC9bef8b2b85de: Merge #11889: Drop extra script variable in ProduceSignature (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJul 31 2019, 20:46

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC9bef8b2b85de: Merge #11889: Drop extra script variable in ProduceSignature.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING9bef8b2b85de: Merge #11889: Drop extra script variable in ProduceSignature.Sep 19 2019, 01:31

Revision Contents
Changeset List

Path

Size

src/

script/

sign.cpp

7 lines

Diff 10557

View Options

Merge #11889: Drop extra script variable in ProduceSignatureClosedPublicActions