Page MenuHomePhabricator

[CMAKE] Fix OSX native build
ClosedPublic

Authored by Fabien on Thu, Aug 1, 14:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC5387896dacfc: [CMAKE] Fix OSX native build
Summary

Cross building for OSX is working, but native cmake build on OSX is
missing some -framework directives to link bitcoin-qt because there
is no QT .prl files to get the dependencies from.
Note that this is the same behavior that autotools build.

Test Plan

On OSX:

mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja

Check the build is successful. Run the generated bitcoin-qt as a
sanity check.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Thu, Aug 1, 14:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Aug 1, 14:37
deadalnix accepted this revision.Mon, Aug 5, 05:10
This revision is now accepted and ready to land.Mon, Aug 5, 05:10
This revision was automatically updated to reflect the committed changes.