[CMAKE] Fix OSX native build
ClosedPublic
Actions

Authored by Fabien on Aug 1 2019, 14:37.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING5387896dacfc: [CMAKE] Fix OSX native build
rABC5387896dacfc: [CMAKE] Fix OSX native build

Summary

Cross building for OSX is working, but native cmake build on OSX is
missing some -framework directives to link bitcoin-qt because there
is no QT .prl files to get the dependencies from.
Note that this is the same behavior that autotools build.

Test Plan

On OSX:

mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja

Check the build is successful. Run the generated bitcoin-qt as a
sanity check.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_fix_osx_native

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7026
Build 12099: Bitcoin ABC Buildbot (legacy)
Build 12098: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 1 2019, 14:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 1 2019, 14:37

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7026: Diff 10565.Aug 1 2019, 14:49

deadalnix accepted this revision.Aug 5 2019, 05:10

This revision is now accepted and ready to land.Aug 5 2019, 05:10

Closed by commit rABC5387896dacfc: [CMAKE] Fix OSX native build (authored by Fabien). · Explain WhyAug 5 2019, 07:17

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5387896dacfc: [CMAKE] Fix OSX native build.

Fabien added a commit: rSTAGING5387896dacfc: [CMAKE] Fix OSX native build.Sep 19 2019, 01:36

Revision Contents
Changeset List

Path

Size

src/

qt/

CMakeLists.txt

6 lines

Diff 10565

View Options

[CMAKE] Fix OSX native buildClosedPublicActions