Page MenuHomePhabricator

Fix some more copies in loops
ClosedPublic

Authored by Fabien on Aug 6 2019, 08:57.

Details

Summary

These copies where catched by clang-7 but not by clang-6.

Test Plan

With clang-7:

ninja check

There should be no -Wrange-loop-analysis warning.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Aug 6 2019, 08:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 6 2019, 08:57
deadalnix accepted this revision.Aug 6 2019, 16:14
This revision is now accepted and ready to land.Aug 6 2019, 16:14
This revision was automatically updated to reflect the committed changes.

@Fabien Note for reference: https://github.com/bitcoin/bitcoin/pull/13241 -- is that backport skippable now?

Fabien added a comment.Aug 9 2019, 06:59

@markblundeberg No need to skip, it's already in: D3795