Page MenuHomePhabricator
Differential D3807

Fix some more copies in loops
ClosedPublic
Actions

Authored by Fabien on Aug 6 2019, 08:57.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGbff1d1290b8a: Fix some more copies in loops
rABCbff1d1290b8a: Fix some more copies in loops
Summary

These copies where catched by clang-7 but not by clang-6.

Test Plan

With clang-7:

ninja check

There should be no -Wrange-loop-analysis warning.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_range_loop_analysis
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7051
Build 12149: Bitcoin ABC Buildbot (legacy)
Build 12148: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 6 2019, 08:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 6 2019, 08:57
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 6 2019, 08:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 6 2019, 09:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7051: Diff 10624.Aug 6 2019, 09:10
deadalnix accepted this revision.Aug 6 2019, 16:14
This revision is now accepted and ready to land.Aug 6 2019, 16:14
Closed by commit rABCbff1d1290b8a: Fix some more copies in loops (authored by Fabien). · Explain WhyAug 7 2019, 08:55
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCbff1d1290b8a: Fix some more copies in loops.
markblundeberg mentioned this in D3810: Merge #13194: Remove template matching and pseudo opcodes.Aug 9 2019, 00:55
markblundeberg added a subscriber: markblundeberg.Aug 9 2019, 02:47

@Fabien Note for reference: https://github.com/bitcoin/bitcoin/pull/13241 -- is that backport skippable now?

Fabien added a comment.Aug 9 2019, 06:59

@markblundeberg No need to skip, it's already in: D3795

Fabien added a commit: rSTAGINGbff1d1290b8a: Fix some more copies in loops.Sep 19 2019, 01:40

Revision Contents
Changeset List

PathSize
src/
script/
2 lines
test/
4 lines
wallet/
15 lines

Diff 10624

View Options

src/script/standard.cpp

Loading...
View Options

src/test/rwcollection_tests.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...