Page MenuHomePhabricator

[CMAKE] Avoid duplicating the compiler/linker flags
ClosedPublic

Authored by Fabien on Aug 8 2019, 14:42.

Details

Summary

This will allow for adding the flags both at top level and in the
submodules (e.g. secp256k1) whithout duplicating them on the command
line, thus allowing these submodules to build standalone.

Note: duplicating the flag is not very expensive as the check result is
already in cache.

Depends on D3825.

Test Plan
ninja

Duplicate a compiler and/or linker flag and run ninja -v.
Check in the output that the flag is not duplicated on the command line.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Aug 8 2019, 14:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 8 2019, 14:42
jasonbcox accepted this revision.Aug 8 2019, 19:34
This revision is now accepted and ready to land.Aug 8 2019, 19:34
This revision was automatically updated to reflect the committed changes.