Page MenuHomePhabricator
Differential D3839

Merge #12947: Wallet hd functional test speedup and clarification
ClosedPublic
Actions

Authored by nakihito on Aug 9 2019, 20:10.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGb4306092e42b: Merge #12947: Wallet hd functional test speedup and clarification
rABCb4306092e42b: Merge #12947: Wallet hd functional test speedup and clarification
Summary

6cba60ace2 speed up wallet_hd.py and clarify/augment checks (Gregory Sanders)

Pull request description:

With `keypool=0` I see no reason to do 300 addresses and sends.

(with --enable-debug)

Before patch:
real	1m10.412s
user	0m49.772s
sys	0m3.988s

After:
real	0m11.566s
user	0m3.344s
sys	0m4.648s

Also added check, since I failed to understand that on startup the wallet already knows about funds by rescanning blocks newer than oldest key birthdate.

Tree-SHA512: cf90f7fe6a437b8b7b1f0707464b9c06085233167826f1a12c3871684664d4d572e13f03e13a718e4537cac39713271c4ac3d9b983e10080b50647caf3cbe82d

Backport of Core PR12947
https://github.com/bitcoin/bitcoin/pull/12947/

Test Plan
test_runnery.py wallet_hd

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Aug 9 2019, 20:10
Owners added a reviewer: Restricted Owners Package.Aug 9 2019, 20:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 9 2019, 20:10
teamcity added a comment.Aug 9 2019, 20:10

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 9 2019, 20:16

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7098: Diff 10701.Aug 9 2019, 20:16
jasonbcox accepted this revision.Aug 9 2019, 21:32
This revision is now accepted and ready to land.Aug 9 2019, 21:32
nakihito updated this revision to Diff 10712.Aug 9 2019, 21:56

Removed newline added to end of timing.json.

teamcity added a comment.Aug 9 2019, 21:56

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 9 2019, 21:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 9 2019, 22:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7107: Diff 10712.Aug 9 2019, 22:07
Closed by commit rABCb4306092e42b: Merge #12947: Wallet hd functional test speedup and clarification (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyAug 9 2019, 23:24
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCb4306092e42b: Merge #12947: Wallet hd functional test speedup and clarification.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGb4306092e42b: Merge #12947: Wallet hd functional test speedup and clarification.Sep 19 2019, 01:43

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines
16 lines

Diff 10715

View Options

test/functional/timing.json

Loading...
View Options

test/functional/wallet_hd.py

Loading...