Page MenuHomePhabricator

Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args
ClosedPublic

Authored by nakihito on Aug 9 2019, 20:40.

Details

Summary

459ea58 rpc: Drop redundant testing of signrawtransaction prevtxs args (Ben Woosley)

Pull request description:

These other types are already tested on line 736.

Tree-SHA512: 2efe777c8a63c69ffe0fafcb2f37f134d324a8bc9525510f1079d2215535b511d6308e5e6eec702a3444f87701236c5e7a22f10bb24e5a454010ef421e5ae900

Backport of Core PR12942
https://github.com/bitcoin/bitcoin/pull/12942/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Aug 9 2019, 20:40
Owners added a reviewer: Restricted Owners Package.Aug 9 2019, 20:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 9 2019, 20:40
jasonbcox accepted this revision.Aug 9 2019, 21:33
This revision is now accepted and ready to land.Aug 9 2019, 21:33
nakihito added a comment.Aug 9 2019, 21:47

Added inline note for documentation's sake.

src/rpc/rawtransaction.cpp
864 ↗(On Diff #10705)

Our testing code is here.