Merge #10642: Remove obsolete _MSC_VER check
ClosedPublic
Actions

Authored by jasonbcox on Aug 9 2019, 21:53.

Details

Reviewers

deadalnix
nakihito

Group Reviewers

Restricted Project

Commits

rSTAGING8cefb20aca9e: Merge #10642: Remove obsolete _MSC_VER check
rABC8cefb20aca9e: Merge #10642: Remove obsolete _MSC_VER check

Summary

700d8d8 Remove obsolete _MSC_VER check (practicalswift)

Tree-SHA512: 3b33f3ce90a3b3b6abec74990fab88402f896402fc563b7081575f85dab05fc7e21fd4c640ca4b9a57a6ca01c5c8ca931be37cac6fa62968fc7b84c719ec6ede

Backport of Core PR10642
https://github.com/bitcoin/bitcoin/pull/10642/files

Test Plan

make

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Aug 9 2019, 21:53

Herald added a reviewer: deadalnix. · View Herald TranscriptAug 9 2019, 21:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7106: Diff 10711.Aug 9 2019, 22:01

Code wise, this looks the same as what I did (even though it is a trivially small/simple change).

This revision is now accepted and ready to land.Aug 9 2019, 22:08

Closed by commit rABC8cefb20aca9e: Merge #10642: Remove obsolete _MSC_VER check (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyAug 13 2019, 17:15

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC8cefb20aca9e: Merge #10642: Remove obsolete _MSC_VER check.

jasonbcox added a commit: rSTAGING8cefb20aca9e: Merge #10642: Remove obsolete _MSC_VER check.Sep 19 2019, 01:47

Revision Contents
Changeset List

Path

Size

src/

init.cpp

2 lines

Diff 10761

View Options

Merge #10642: Remove obsolete _MSC_VER checkClosedPublicActions