Page MenuHomePhabricator

Merge #11842: [build] Add missing stuff to clean-local
ClosedPublic

Authored by jasonbcox on Aug 9 2019, 22:12.

Details

Summary

b341143 [build] Add missing stuff to clean-local - test/functional/test_framework/__pycache__ - test/cache (Karl-Johan Alm)

Pull request description:

After doing
```
./autogen.sh && ./configure && make
make clean
make distclean
```
and moving `.gitignore` aside, the following files still remain after this patch:
```
	Makefile.in
	aclocal.m4
	autom4te.cache/
	build-aux/compile
	build-aux/config.guess
	build-aux/config.sub
	build-aux/depcomp
	build-aux/install-sh
	build-aux/ltmain.sh
	build-aux/m4/libtool.m4
	build-aux/m4/ltoptions.m4
	build-aux/m4/ltsugar.m4
	build-aux/m4/ltversion.m4
	build-aux/m4/lt~obsolete.m4
	build-aux/missing
	build-aux/test-driver
	configure
	doc/man/Makefile.in
	src/Makefile.in
	src/config/bitcoin-config.h.in
```

Most are automake related so I guess it's fine if they litter around.

Tree-SHA512: 7566f56a79932cc1d6ee6ff487d121e3909db57167775e1b27209d93bcc1c14e47b0fcc9c0c272c4b9df907c1bc0664f02006a21b3b6939fa50fc2a5762729e4

Backport Core PR 11842
https://github.com/bitcoin/bitcoin/pull/11842/files

Test Plan

Apparently this only affects in-tree builds because these files already do not exist in out-of-tree builds.
I didn't want to garbage up my tree, so didn't really test it beyond making sure an out-of-tree make clean
isn't broken.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11842
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7108
Build 12262: Bitcoin ABC Teamcity Staging
Build 12261: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Aug 9 2019, 22:12
Fabien accepted this revision.Aug 12 2019, 07:00
This revision is now accepted and ready to land.Aug 12 2019, 07:00