Page MenuHomePhabricator

Merge #11573: [Util] Update tinyformat.h
ClosedPublic

Authored by nakihito on Aug 9 2019, 22:32.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING87684f13e3fa: Merge #11573: [Util] Update tinyformat.h
rABC87684f13e3fa: Merge #11573: [Util] Update tinyformat.h
Summary

60b98f8 [Util] Update tinyformat.h (fanquake)

Pull request description:

Updates `tinyformat.h` to commit c42f/tinyformat@689695c upstream. Including:
https://github.com/c42f/tinyformat/commit/8a2812d8480bfb66923eea0bb5cdda79fe4f17ba
https://github.com/c42f/tinyformat/commit/5d9e05a3479d1b2ec6a4602fd797f0ec26440db2
https://github.com/c42f/tinyformat/commit/48e2e48789907f80a7aec24a3f1d69196b78ed43

@achow101 mentioned that since upgrading to Ubuntu 17.10 (GCC 7), tinyformat had been throwing lots of -Wimplicit-fallthrough warnings. However fallthrough warnings should have been silenced by #10489. cc @theuni.

The upstream commit to fix fallthrough warnings is in this PR https://github.com/c42f/tinyformat/pull/39.

The last time tinyformat.h was updated in this repo was in #8274.

Tree-SHA512: a51bd30544693550e08148daf5d244e3a3a410caff7897351eb9cd28f661dc85e193e045bb86068ee4006b2f89a7233b7573b8c50d93d2a9a15a11386fdcc605

Backport of Core PR11573
https://github.com/bitcoin/bitcoin/pull/11573/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.