Page MenuHomePhabricator
Differential D3864

[teamcity/gitian] Do not remove src tarball from results
ClosedPublic
Actions

Authored by jasonbcox on Aug 13 2019, 00:41.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING5fcd849b0278: [teamcity/gitian] Do not remove src tarball from results
rABC5fcd849b0278: [teamcity/gitian] Do not remove src tarball from results
Summary

Reasons to delete the src tarball:

  • Save disk space

Reasons to keep it:

  • Easily package a release from TeamCity (if needed)
  • Verify and/or manually test the src tarball.
  • TeamCity automatically cleans up old build artifacts, so disk space is not really an issue.

I'm in favor of keeping it.

Test Plan

TeamCity gitian build (see comments)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Aug 13 2019, 00:41
Herald added a reviewer: deadalnix. · View Herald TranscriptAug 13 2019, 00:41
teamcity added a comment.Aug 13 2019, 00:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 13 2019, 00:43

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Aug 13 2019, 00:43
teamcity added a comment.Aug 13 2019, 00:55

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7130: Diff 10750.Aug 13 2019, 00:55
teamcity added a comment.Aug 13 2019, 01:02

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Fabien accepted this revision.Aug 13 2019, 07:40
This revision is now accepted and ready to land.Aug 13 2019, 07:40
Closed by commit rABC5fcd849b0278: [teamcity/gitian] Do not remove src tarball from results (authored by jasonbcox). · Explain WhyAug 13 2019, 17:45
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC5fcd849b0278: [teamcity/gitian] Do not remove src tarball from results.
jasonbcox added a commit: rSTAGING5fcd849b0278: [teamcity/gitian] Do not remove src tarball from results.Sep 19 2019, 01:47

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
1 line

Diff 10762

View Options

contrib/teamcity/gitian.sh

Loading...