Merge #12837: rpc: fix type mistmatch in `listreceivedbyaddress`
ClosedPublic
Actions

Authored by nakihito on Aug 15 2019, 19:35.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING03bdf2f3aed8: Merge #12837: rpc: fix type mistmatch in `listreceivedbyaddress`
rABC03bdf2f3aed8: Merge #12837: rpc: fix type mistmatch in `listreceivedbyaddress`

Summary

05c03d1249 rpc: fix type mistmatch in listreceivedbyaddress (joemphilips)

Pull request description:

`txids` filed in return value is supposed be `string` but it was `numeric` in the help message

Tree-SHA512: 7d860994c2d1d9149b41fd7afefc1a44460eede5a023070fcc18b0a4a19a26c5eec5abd157038c15fe7d50a3390bdaf7a4823279129eb1458b0d3c6141a533ee

Backport of Core PR12837
https://github.com/bitcoin/bitcoin/pull/12837/

Test Plan

make check
./bitcoind
./bitcoin-cli help listreceivedbyaddress

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Aug 15 2019, 19:35

Owners added a reviewer: Restricted Owners Package.Aug 15 2019, 19:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 15 2019, 19:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7165: Diff 10816.Aug 15 2019, 19:47

jasonbcox accepted this revision.Aug 16 2019, 00:43

This revision is now accepted and ready to land.Aug 16 2019, 00:43

Closed by commit rABC03bdf2f3aed8: Merge #12837: rpc: fix type mistmatch in `listreceivedbyaddress` (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyAug 16 2019, 18:47

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC03bdf2f3aed8: Merge #12837: rpc: fix type mistmatch in `listreceivedbyaddress`.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING03bdf2f3aed8: Merge #12837: rpc: fix type mistmatch in `listreceivedbyaddress`.Sep 19 2019, 01:52

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

2 lines

Diff 10834

View Options

Merge #12837: rpc: fix type mistmatch in `listreceivedbyaddress`ClosedPublicActions