Page MenuHomePhabricator
Differential D3894

Merge #12737: Remove unnecessary NONNEGATIVE_SIGNED
AbandonedPublic
Actions

Authored by nakihito on Aug 16 2019, 19:44.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

34ca750320 Remove unnecessary NONNEGATIVE_SIGNED (Russell Yanofsky)

Pull request description:

Switch to unsigned encoding, which is backwards compatible and avoids MSVC
error reported https://github.com/bitcoin/bitcoin/issues/12732

Tree-SHA512: 9687842aa8cb745ba7cf7612bd2feea0cef14953aba9af26c72c6eb3c974d790152eb4d0e8654d4ae451fe80947cb2552a82f19b1f9e9658701aed8ce0ee5c23

Backport of Core PR12737
https://github.com/bitcoin/bitcoin/pull/12737/

Test Plan
make check

Run a windows build and verify the following error does not occur:

Error C2338 Signed type required with mode NONNEGATIVE_SIGNED. libbitcoin_server {path}\src\serialize.h 316

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12737
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8225
Build 14476: Default Diff Build & Tests
Build 14475: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 16 2019, 19:44
Owners added a reviewer: Restricted Owners Package.Aug 16 2019, 19:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 16 2019, 19:44
nakihito planned changes to this revision.Aug 16 2019, 19:44
teamcity added a comment.Aug 16 2019, 19:44

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 16 2019, 19:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 16 2019, 19:52

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7175: Diff 10836.Aug 16 2019, 19:52
nakihito updated this revision to Diff 14318.Nov 22 2019, 00:50

Included change for rpc/blockchain.cpp.

nakihito planned changes to this revision.Nov 22 2019, 00:50
teamcity added a comment.Nov 22 2019, 00:52

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

nakihito edited the test plan for this revision. (Show Details)Nov 22 2019, 00:55
teamcity added a comment.Nov 22 2019, 01:07

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Nov 22 2019, 01:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 22 2019, 02:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8225: Diff 14318.Nov 22 2019, 02:10
nakihito requested review of this revision.Nov 22 2019, 19:57
nakihito edited the test plan for this revision. (Show Details)
deadalnix requested changes to this revision.Nov 23 2019, 14:59

What is this doing? Why is this necessary? Clearly, this isn't removing unnecessary NONNEGATIVE_SIGNED, because these never were there in the first place.

This revision now requires changes to proceed.Nov 23 2019, 14:59
nakihito abandoned this revision.Jan 3 2020, 20:45

Revision Contents
Changeset List

PathSize
src/
rpc/
4 lines
4 lines

Diff 14318

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/undo.h

Loading...