Add python3 to list of dependencies on some platforms
ClosedPublic
Actions

Authored by Fabien on Aug 19 2019, 09:19.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING9cc957a53e8e: Add python3 to list of dependencies on some platforms
rABC9cc957a53e8e: Add python3 to list of dependencies on some platforms

Summary

python3 is required for running the unit tests on macOS, Ubuntu and
Fedora.

Without python3 installed, 'make check' fails because
/test/util/bitcoin-util-test.py fails to find python3.

Backport of core PR11136
https://github.com/bitcoin/bitcoin/pull/11136/files

Depends on D3904.

Test Plan

Read it.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11136

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7186
Build 12417: Bitcoin ABC Buildbot (legacy)
Build 12416: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 19 2019, 09:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 19 2019, 09:19

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7186: Diff 10855.Aug 19 2019, 09:26

Fabien added a child revision: D3908: remove brew c++ flag.Aug 19 2019, 12:33

jasonbcox accepted this revision.Aug 19 2019, 17:49

This revision is now accepted and ready to land.Aug 19 2019, 17:49

Closed by commit rABC9cc957a53e8e: Add python3 to list of dependencies on some platforms (authored by danra <danra@users.noreply.github.com>, committed by Fabien). · Explain WhyAug 19 2019, 21:04

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9cc957a53e8e: Add python3 to list of dependencies on some platforms.

Fabien added a commit: rSTAGING9cc957a53e8e: Add python3 to list of dependencies on some platforms.Sep 19 2019, 01:55

Revision Contents
Changeset List

Path

Size

doc/

build-osx.md

2 lines

build-unix.md

4 lines

Diff 10855

View Options

doc/build-osx.md