remove brew c++ flag
ClosedPublic
Actions

Authored by Fabien on Aug 19 2019, 12:33.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING2cc302e91810: remove brew c++ flag
rABC2cc302e91810: remove brew c++ flag

Summary

the c++ is not needed since the listed brew formulas no longer have this
option. It also raises a warning that may generate confusion.

Backport of core PR12027
https://github.com/bitcoin/bitcoin/pull/12027/files

Depends on D3905.

Expected to fix https://github.com/Bitcoin-ABC/bitcoin-abc/issues/338.

Test Plan

Read it, test it.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12027

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7189
Build 12423: Bitcoin ABC Buildbot (legacy)
Build 12422: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 19 2019, 12:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 19 2019, 12:33

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7189: Diff 10858.Aug 19 2019, 12:40

Fabien added a child revision: D3909: docs: Update osx brew install instruction.Aug 19 2019, 12:43

jasonbcox accepted this revision.Aug 19 2019, 17:52

This revision is now accepted and ready to land.Aug 19 2019, 17:52

Closed by commit rABC2cc302e91810: remove brew c++ flag (authored by Pablo Fernandez <fernandezpablo85@gmail.com>, committed by Fabien). · Explain WhyAug 19 2019, 21:08

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2cc302e91810: remove brew c++ flag.

Fabien added a commit: rSTAGING2cc302e91810: remove brew c++ flag.Sep 19 2019, 01:55

Revision Contents
Changeset List

Path

Size

doc/

build-osx.md

2 lines

Diff 10858

View Options

remove brew c++ flagClosedPublicActions