Page MenuHomePhabricator
Differential D3924

Cleanup TODOs leftover from PR14119 backporting
ClosedPublic
Actions

Authored by jasonbcox on Aug 20 2019, 22:09.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING2b80f23c116d: Cleanup TODOs leftover from PR14119 backporting
rABC2b80f23c116d: Cleanup TODOs leftover from PR14119 backporting
Summary

Final cleanup after PR14119
https://github.com/bitcoin/bitcoin/pull/14119/files

Depends on D3922, D3923, and others already landed

Test Plan

test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14119-cleanup-final
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7211
Build 12467: Bitcoin ABC Buildbot (legacy)
Build 12466: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Aug 20 2019, 22:09
Herald added a reviewer: deadalnix. · View Herald TranscriptAug 20 2019, 22:09
jasonbcox planned changes to this revision.Aug 20 2019, 22:09
teamcity added a comment.Aug 20 2019, 22:10

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Aug 20 2019, 22:11
jasonbcox added parent revisions: D3923: Cleanup reject_code in abc-schnorr.py, D3922: Cleanup reject_code in abc-segwit-recovery.
teamcity added a comment.Aug 20 2019, 22:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7211: Diff 10898.Aug 20 2019, 22:17
jasonbcox requested review of this revision.Aug 20 2019, 22:18
Fabien accepted this revision.Aug 21 2019, 09:25
Fabien added a subscriber: Fabien.

Please update the test plan to run the extended tests (did run them, no issue).

This revision is now accepted and ready to land.Aug 21 2019, 09:25
jasonbcox edited the test plan for this revision. (Show Details)Aug 21 2019, 15:34
Closed by commit rABC2b80f23c116d: Cleanup TODOs leftover from PR14119 backporting (authored by jasonbcox). · Explain WhyAug 21 2019, 15:35
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC2b80f23c116d: Cleanup TODOs leftover from PR14119 backporting.
jasonbcox added a commit: rSTAGING2b80f23c116d: Cleanup TODOs leftover from PR14119 backporting.Sep 19 2019, 01:58

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
12 lines

Diff 10898

View Options

test/functional/test_framework/mininode.py

Loading...