Page MenuHomePhabricator

trivial: Improve include comment in src/interfaces/wallet.h
ClosedPublic

Authored by fpelliccioni on Wed, Aug 21, 18:16.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC613c7d202468: trivial: Improve include comment in src/interfaces/wallet.h
Summary

Backport of Bitcoin Core PR13026
https://github.com/bitcoin/bitcoin/pull/13026

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fpelliccioni created this revision.Wed, Aug 21, 18:16
Owners added a reviewer: Restricted Owners Package.Wed, Aug 21, 18:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Aug 21, 18:16
fpelliccioni updated this revision to Diff 10914.Wed, Aug 21, 18:23

Fix indentation

Fabien requested changes to this revision.Wed, Aug 21, 19:18

Please use PR12345 in the summary (no #) and use markdown to make the test plan look pretty.

src/interfaces/wallet.h
10 ↗(On Diff #10914)

Move the comment above #include <pubkey.h>

This revision now requires changes to proceed.Wed, Aug 21, 19:18
deadalnix added inline comments.Wed, Aug 21, 19:21
src/interfaces/wallet.h
10 ↗(On Diff #10914)

It's fine this way. clang-format handles is gracefully.

fpelliccioni edited the summary of this revision. (Show Details)Thu, Aug 22, 12:30
fpelliccioni edited the test plan for this revision. (Show Details)
fpelliccioni marked 2 inline comments as done.
In D3930#92157, @Fabien wrote:

Please use PR12345 in the summary (no #) and use markdown to make the test plan look pretty.

Fixed and added the PR link to github.

src/interfaces/wallet.h
10 ↗(On Diff #10914)

I followed Amaury's recommendation.

fpelliccioni updated this revision to Diff 10923.Thu, Aug 22, 13:25
fpelliccioni edited the summary of this revision. (Show Details)

Fixed Diff summary and test case.

Fabien accepted this revision.Thu, Aug 22, 13:33
This revision is now accepted and ready to land.Thu, Aug 22, 13:33