Page MenuHomePhabricator

use base58 map instead of strchr()
ClosedPublic

Authored by fpelliccioni on Aug 22 2019, 19:36.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING7b0d5028a6b5: use base58 map instead of strchr()
rABC7b0d5028a6b5: use base58 map instead of strchr()
Summary

Backport of Bitcoin Core PR12704
https://github.com/bitcoin/bitcoin/pull/12704

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-ad823178e
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7228
Build 12501: Bitcoin ABC Buildbot (legacy)
Build 12500: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 22 2019, 19:36
Fabien requested changes to this revision.Aug 23 2019, 13:49
Fabien added inline comments.
src/base58.cpp
54

Move the comment in its own line above.

58

Dito + add braces:

// Invalid b58 character
if (carry == -1) {
    return false;
}
This revision now requires changes to proceed.Aug 23 2019, 13:49
This revision is now accepted and ready to land.Aug 26 2019, 14:21