Page MenuHomePhabricator
Differential D3956

Shell script cleanups
ClosedPublic
Actions

Authored by Fabien on Aug 28 2019, 08:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING66a6e8250474: Shell script cleanups
rABC66a6e8250474: Shell script cleanups
Summary
Shell script cleanups:

  - Add required space to [ -n ].
  - Avoid quote within quote.
  - Exit if cd fails.
  - Remove \n which is not handled by echo.

Backport of core PR10773
https://github.com/bitcoin/bitcoin/pull/10773/files

Note: tidy_datadir.sh, gitian-build.sh and verify_commits.sh have
been deleted from our codebase.

Depends on D3955.

Test Plan

Run the scripts (build the project to test genbuild.sh).
I did not test the detached-sig-create.sh script which is just an
echo change, not the verify.sh which is obsolete and need rework.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 28 2019, 08:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2019, 08:18
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 28 2019, 08:18

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 28 2019, 08:26

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7253: Diff 10982.Aug 28 2019, 08:26
Fabien added a child revision: D3959: Add shell script linting: Check for shellcheck warnings in shell scripts.Aug 28 2019, 09:56
deadalnix accepted this revision.Aug 28 2019, 12:23
deadalnix added inline comments.
contrib/verifybinaries/verify.sh
33 ↗(On Diff #10982)

It's probably a good idea to enforce setting various bash flags with a linter, such as set -euxo pipefail or alike.

This revision is now accepted and ready to land.Aug 28 2019, 12:23
Closed by commit rABC66a6e8250474: Shell script cleanups (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyAug 28 2019, 12:42
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC66a6e8250474: Shell script cleanups.
Fabien added a commit: rSTAGING66a6e8250474: Shell script cleanups.Sep 19 2019, 02:02

Revision Contents
Changeset List

PathSize
contrib/
devtools/
2 lines
macdeploy/
2 lines
verifybinaries/
6 lines
share/
2 lines

Diff 10989

View Options

contrib/devtools/gen-manpages.sh

Loading...
View Options

contrib/macdeploy/detached-sig-create.sh

Loading...
View Options

contrib/verifybinaries/verify.sh

Loading...
View Options

share/genbuild.sh

Loading...