Page MenuHomePhabricator

Add shell script linting: Check for shellcheck warnings in shell scripts

Authored by Fabien on Aug 28 2019, 09:56.



Adapted to run as an Arcanist linter, and added fixes for the scripts
which are Bitcoin ABC only.

Because the quantity of shell script is limited, the performance cost is
almost unnoticeable.

Backport of core PR12871

Depends on D3956, D3957 and D3958.

Test Plan

Should return no error:

arc lint --everything

Add an unsused variable in a script and lint that file:

arc lint -- <the_script_file>

Check the linter returns a warning.

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.