Add shell script linting: Check for shellcheck warnings in shell scripts
Summary:
Adapted to run as an Arcanist linter, and added fixes for the scripts
which are Bitcoin ABC only.
Because the quantity of shell script is limited, the performance cost is
almost unnoticeable.
Backport of core PR12871
https://github.com/bitcoin/bitcoin/pull/12871/files
Depends on D3956, D3957 and D3958.
Test Plan:
Should return no error:
arc lint --everything
Add an unsused variable in a script and lint that file:
arc lint -- <the_script_file>
Check the linter returns a warning.
Reviewers: #bitcoin_abc, deadalnix
Reviewed By: #bitcoin_abc, deadalnix
Differential Revision: https://reviews.bitcoinabc.org/D3959